Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/browser/devtools/devtools_protocol.h

Issue 22685003: Visualize status of port forwarding sockets in chrome:inspect Devices tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_protocol.h
diff --git a/chrome/browser/devtools/devtools_protocol.h b/chrome/browser/devtools/devtools_protocol.h
index 9a01eee531373b65e21b95d311a9e20905a2a55a..c781858c15b0c7b7e84f98cd9985f7699ac5842e 100644
--- a/chrome/browser/devtools/devtools_protocol.h
+++ b/chrome/browser/devtools/devtools_protocol.h
@@ -38,7 +38,7 @@ class DevToolsProtocol {
public:
// Takes ownership of |params|.
Command(int id, const std::string& method, base::DictionaryValue* params);
- virtual ~Command();
+ virtual ~Command();
int id() { return id_; }
std::string Serialize();
@@ -49,6 +49,23 @@ class DevToolsProtocol {
DISALLOW_COPY_AND_ASSIGN(Command);
};
+ class Response {
+ public:
+ virtual ~Response();
+
+ int id() { return id_; }
+ int error_code() { return error_code_; }
+
+ private:
+ friend class DevToolsProtocol;
+
+ Response(int id, int error_code);
+ int id_;
+ int error_code_;
+
+ DISALLOW_COPY_AND_ASSIGN(Response);
+ };
+
class Notification : public Message {
public:
virtual ~Notification();
@@ -65,6 +82,8 @@ class DevToolsProtocol {
static Notification* ParseNotification(const std::string& json);
+ static Response* ParseResponse(const std::string& json);
pfeldman 2013/08/08 16:43:22 Please add comment suggesting that ownership is pa
Vladislav Kaznacheev 2013/08/09 08:24:58 On 2013/08/08 16:43:22, pfeldman wrote: > Please a
+
private:
DevToolsProtocol() {}

Powered by Google App Engine
This is Rietveld 408576698