Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2268443002: add SkMatrixPriv for specialized helpers

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -20 lines) Patch
M include/core/SkMatrix.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +17 lines, -9 lines 0 comments Download
A src/core/SkMatrixPriv.h View 1 chunk +70 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/batches/GrNonAAFillRectBatch.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
reed1
I changed the gm simplerects to have a translate (instead of identity ctm) and it ...
4 years, 4 months ago (2016-08-21 21:15:08 UTC) #5
reed1
There are a few gm diffs (mostly in the low bit or 2), esp. in ...
4 years, 4 months ago (2016-08-21 21:37:45 UTC) #8
bsalomon
Slight GM changes are not surprising. I like this idea. lgtm.
4 years, 4 months ago (2016-08-22 13:29:41 UTC) #9
reed1
Guess we'll cross our fingers on the DEPS roll ...
4 years, 4 months ago (2016-08-22 13:38:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268443002/1
4 years, 4 months ago (2016-08-22 13:38:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a39667c848146d9070e1a45662fb292d8e6bb8fb
4 years, 4 months ago (2016-08-22 13:39:52 UTC) #15
mtklein
On 2016/08/22 13:38:39, reed1 wrote: > Guess we'll cross our fingers on the DEPS roll ...
4 years, 4 months ago (2016-08-22 13:40:27 UTC) #16
bungeman-skia
4 years, 4 months ago (2016-08-22 14:25:34 UTC) #18
On 2016/08/22 13:40:27, mtklein wrote:
> On 2016/08/22 13:38:39, reed1 wrote:
> > Guess we'll cross our fingers on the DEPS roll ...
> 
> (You can trigger Blink layout test trybots here now...)

And... it probably won't matter, since 'analyze' apparently doesn't think a
change to SkMatrix could possibly affect layout tests.

Powered by Google App Engine
This is Rietveld 408576698