Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp

Issue 2268433002: binding: Removes unused code in templates/attributes.cpp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/templates/attributes.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp b/third_party/WebKit/Source/bindings/templates/attributes.cpp
index a76fbbc83f92e15531ba853cdddc144c50f4e86f..4ae6427e6f435a189c7b42f0301aea9bb29d8855 100644
--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp
+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp
@@ -9,11 +9,6 @@ const v8::PropertyCallbackInfo<v8::Value>& info
const v8::FunctionCallbackInfo<v8::Value>& info
{%- endif %})
{
- {% if attribute.is_reflect and not attribute.is_url
- and attribute.idl_type == 'DOMString' and is_node
- and not attribute.is_implemented_in_private_script %}
- {% set cpp_class, v8_class = 'Element', 'V8Element' %}
- {% endif %}
{# holder #}
{% if not attribute.is_static %}
{% if attribute.is_lenient_this %}
@@ -53,10 +48,6 @@ const v8::FunctionCallbackInfo<v8::Value>& info
}
}
{% endif %}
- {% if interface_name == 'Window' and attribute.idl_type == 'EventHandler' %}
- if (!impl->document())
- return;
- {% endif %}
{# Local variables #}
{% if attribute.is_call_with_execution_context %}
ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
@@ -243,10 +234,6 @@ v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
{%- endif %})
{
- {% if attribute.is_reflect and attribute.idl_type == 'DOMString'
- and is_node and not attribute.is_implemented_in_private_script %}
- {% set cpp_class, v8_class = 'Element', 'V8Element' %}
- {% endif %}
{% if attribute.has_setter_exception_state or
((not attribute.is_replaceable and
not attribute.constructor_type and
@@ -287,10 +274,6 @@ v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
not attribute.constructor_type %}
{{cpp_class}}* impl = {{v8_class}}::toImpl(holder);
{% endif %}
- {% if attribute.idl_type == 'EventHandler' and interface_name == 'Window' %}
- if (!impl->document())
- return;
- {% endif %}
{# Security checks #}
{% if not attribute.is_replaceable and
not attribute.constructor_type %}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698