Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2268433002: binding: Removes unused code in templates/attributes.cpp. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Removes unused code in templates/attributes.cpp. Faking {{cpp_class}} and {{c8_class}} doesn't make sense. Probably it made sense before the introduction of virtual ScriptWrappable::wrap(). Checking the existence of window->document() doesn't seem making sense to me, and CQ tests seem passing without the check. BUG= Committed: https://crrev.com/7a6d81a8544c595331b50a17f8c0b11feca2f029 Cr-Commit-Position: refs/heads/master@{#413375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M third_party/WebKit/Source/bindings/templates/attributes.cpp View 4 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Yuki
Could you review this CL?
4 years, 4 months ago (2016-08-21 13:07:10 UTC) #12
haraken
LGTM
4 years, 4 months ago (2016-08-21 13:08:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268433002/1
4 years, 4 months ago (2016-08-21 13:09:14 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 13:12:48 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 13:14:34 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a6d81a8544c595331b50a17f8c0b11feca2f029
Cr-Commit-Position: refs/heads/master@{#413375}

Powered by Google App Engine
This is Rietveld 408576698