Revert of Make calling SetHeader() with invalid value fatal

Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
>
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
>
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
>
> If you see a crash attributed to this CL:
>
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
>
> BUG=627398
>
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
Committed: https://crrev.com/6c2cdfb89375fe0734615bd8081283d25fb0aad5
Cr-Commit-Position: refs/heads/master@{#414633}

[Adam Rice, 2016-08-24 02:52:09]

Created Revert of Make calling SetHeader() with invalid value fatal

[Adam Rice, 2016-08-24 02:52:38]

Description was changed from

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
> 
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
> 
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
> 
> If you see a crash attributed to this CL:
> 
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
> 
> BUG=627398
> 
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

TBR=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
==========

to

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
> 
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
> 
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
> 
> If you see a crash attributed to this CL:
> 
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
> 
> BUG=627398
> 
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
==========

[Adam Rice, 2016-08-24 02:52:46]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 02:53:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 05:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 05:02:54]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-08-25 19:31:08]

On 2016/08/24 02:52:09, Adam Rice wrote:
> Created Revert of Make calling SetHeader() with invalid value fatal

LGTM.  Sorry for the delay, thought you just TBRed this.

[mmenke, 2016-08-25 19:31:13]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:39:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Adam Rice, 2016-08-26 01:22:48]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:23:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-08-26 01:23:39]

On 2016/08/25 19:31:08, mmenke (busy) wrote:
> LGTM.  Sorry for the delay, thought you just TBRed this.

Sorry for the confusion. That's probably what I should have done.

[commit-bot: I haz the power, 2016-08-26 02:29:34]

Description was changed from

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
> 
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
> 
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
> 
> If you see a crash attributed to this CL:
> 
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
> 
> BUG=627398
> 
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
==========

to

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
> 
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
> 
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
> 
> If you see a crash attributed to this CL:
> 
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
> 
> BUG=627398
> 
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
==========

[commit-bot: I haz the power, 2016-08-26 02:29:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 02:33:34]

Description was changed from

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
> 
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
> 
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
> 
> If you see a crash attributed to this CL:
> 
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
> 
> BUG=627398
> 
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398
==========

to

==========
Revert of Make calling SetHeader() with invalid value fatal (patchset #1 id:1 of
https://codereview.chromium.org/2143903002/ )

Reason for revert:
This CL has served its purpose of finding bad callers of SetHeader() and should
be reverted before the branch point.

Original issue's description:
> Make calling SetHeader() with invalid value fatal
>
> crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
> individual CR and NL as well as CRNL.
>
> I believe that all callers of net::HttpRequestHeaders::SetHeader() and
> SetHeaderIfMissing() which use user-supplied values already verify the
> value with IsValidHeaderValue() first. However, to be sure, temporarily
> make it a fatal error to call SetHeader() with an invalid value.
>
> If you see a crash attributed to this CL:
>
> 1. Associate it with the bug.
> 2. Follow the stack flow to work out how untrusted data ended up
> being passed to SetHeader().
> 3. Add a call to IsValidHeaderValue() at the point where the untrusted
> data was introduced. A tighter check such as IsToken() may be appopriate.
>
> BUG=627398
>
> Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
> Cr-Commit-Position: refs/heads/master@{#405702}

R=mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=627398

Committed: https://crrev.com/6c2cdfb89375fe0734615bd8081283d25fb0aad5
Cr-Commit-Position: refs/heads/master@{#414633}
==========

[commit-bot: I haz the power, 2016-08-26 02:33:35]

Patchset 1 (id:??) landed as
https://crrev.com/6c2cdfb89375fe0734615bd8081283d25fb0aad5
Cr-Commit-Position: refs/heads/master@{#414633}