Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: ui/gfx/geometry/rect_unittest.cc

Issue 2268423003: Adjust gfx::Rect's width and height to avoid integer overflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/geometry/rect.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/geometry/rect_unittest.cc
diff --git a/ui/gfx/geometry/rect_unittest.cc b/ui/gfx/geometry/rect_unittest.cc
index be4b462073671ccef217627f2c6977be5299ff08..7963cc0bbbf41562865126e200994a78a923786f 100644
--- a/ui/gfx/geometry/rect_unittest.cc
+++ b/ui/gfx/geometry/rect_unittest.cc
@@ -915,4 +915,81 @@ TEST(RectTest, ManhattanInternalDistance) {
f.ManhattanInternalDistance(gfx::RectF(-1.5f, 0.0f, 1.5f, 1.0f)));
}
+TEST(RectTest, IntegerOverflow) {
+ int expected = 10;
+ int large_number = std::numeric_limits<int>::max() - expected;
+
+ Rect height_overflow(0, large_number, 100, 100);
+ EXPECT_EQ(large_number, height_overflow.y());
+ EXPECT_EQ(expected, height_overflow.height());
+
+ Rect width_overflow(large_number, 0, 100, 100);
+ EXPECT_EQ(large_number, width_overflow.x());
+ EXPECT_EQ(expected, width_overflow.width());
+
+ Rect size_height_overflow(Point(0, large_number), Size(100, 100));
+ EXPECT_EQ(large_number, size_height_overflow.y());
+ EXPECT_EQ(expected, size_height_overflow.height());
+
+ Rect size_width_overflow(Point(large_number, 0), Size(100, 100));
+ EXPECT_EQ(large_number, size_width_overflow.x());
+ EXPECT_EQ(expected, size_width_overflow.width());
+
+ Rect set_height_overflow(0, large_number, 100, 5);
+ EXPECT_EQ(5, set_height_overflow.height());
+ set_height_overflow.set_height(100);
+ EXPECT_EQ(expected, set_height_overflow.height());
+
+ Rect set_y_overflow(100, 100, 100, 100);
+ EXPECT_EQ(100, set_y_overflow.height());
+ set_y_overflow.set_y(large_number);
+ EXPECT_EQ(expected, set_y_overflow.height());
+
+ Rect set_width_overflow(large_number, 0, 5, 100);
+ EXPECT_EQ(5, set_width_overflow.width());
+ set_width_overflow.set_width(100);
+ EXPECT_EQ(expected, set_width_overflow.width());
+
+ Rect set_x_overflow(100, 100, 100, 100);
+ EXPECT_EQ(100, set_x_overflow.width());
+ set_x_overflow.set_x(large_number);
+ EXPECT_EQ(expected, set_x_overflow.width());
+
+ Point large_offset(large_number, large_number);
+ Size size(100, 100);
+ Size expected_size(10, 10);
+
+ Rect set_origin_overflow(100, 100, 100, 100);
+ EXPECT_EQ(size, set_origin_overflow.size());
+ set_origin_overflow.set_origin(large_offset);
+ EXPECT_EQ(large_offset, set_origin_overflow.origin());
+ EXPECT_EQ(expected_size, set_origin_overflow.size());
+
+ Rect set_size_overflow(large_number, large_number, 5, 5);
+ EXPECT_EQ(Size(5, 5), set_size_overflow.size());
+ set_size_overflow.set_size(size);
+ EXPECT_EQ(large_offset, set_size_overflow.origin());
+ EXPECT_EQ(expected_size, set_size_overflow.size());
+
+ Rect set_rect_overflow;
+ set_rect_overflow.SetRect(large_number, large_number, 100, 100);
+ EXPECT_EQ(large_offset, set_rect_overflow.origin());
+ EXPECT_EQ(expected_size, set_rect_overflow.size());
+
+ Rect inset_overflow;
+ inset_overflow.Inset(large_number, large_number, 100, 100);
+ EXPECT_EQ(large_offset, inset_overflow.origin());
+ EXPECT_EQ(expected_size, inset_overflow.size());
+
+ Rect offset_overflow(0, 0, 100, 100);
+ offset_overflow.Offset(large_number, large_number);
+ EXPECT_EQ(large_offset, offset_overflow.origin());
+ EXPECT_EQ(expected_size, offset_overflow.size());
+
+ Rect operator_overflow(0, 0, 100, 100);
+ operator_overflow += Vector2d(large_number, large_number);
+ EXPECT_EQ(large_offset, operator_overflow.origin());
+ EXPECT_EQ(expected_size, operator_overflow.size());
+}
+
} // namespace gfx
« no previous file with comments | « ui/gfx/geometry/rect.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698