Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h

Issue 2268403006: Use background thread for AsyncAudioDecoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits after l-g-t-m Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, Google Inc. All rights reserved. 2 * Copyright (C) 2011, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y 16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N 19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #ifndef AsyncAudioDecoder_h 25 #ifndef AsyncAudioDecoder_h
26 #define AsyncAudioDecoder_h 26 #define AsyncAudioDecoder_h
27 27
28 #include "platform/heap/Handle.h" 28 #include "platform/heap/Handle.h"
29 #include "public/platform/WebThread.h"
30 #include "wtf/build_config.h" 29 #include "wtf/build_config.h"
31 #include <memory> 30 #include <memory>
32 31
33 namespace blink { 32 namespace blink {
34 33
35 class BaseAudioContext; 34 class BaseAudioContext;
36 class AudioBuffer; 35 class AudioBuffer;
37 class AudioBufferCallback; 36 class AudioBufferCallback;
38 class AudioBus; 37 class AudioBus;
39 class DOMArrayBuffer; 38 class DOMArrayBuffer;
40 class ScriptPromiseResolver; 39 class ScriptPromiseResolver;
41 40
42 // AsyncAudioDecoder asynchronously decodes audio file data from a DOMArrayBuffe r in a worker thread. 41 // AsyncAudioDecoder asynchronously decodes audio file data from a
43 // Upon successful decoding, a completion callback will be invoked with the deco ded PCM data in an AudioBuffer. 42 // DOMArrayBuffer in the background thread. Upon successful decoding, a
43 // completion callback will be invoked with the decoded PCM data in an
44 // AudioBuffer.
44 45
45 class AsyncAudioDecoder { 46 class AsyncAudioDecoder {
46 DISALLOW_NEW(); 47 DISALLOW_NEW();
47 WTF_MAKE_NONCOPYABLE(AsyncAudioDecoder); 48 WTF_MAKE_NONCOPYABLE(AsyncAudioDecoder);
48 public: 49 public:
49 AsyncAudioDecoder(); 50 AsyncAudioDecoder() { };
50 ~AsyncAudioDecoder(); 51 ~AsyncAudioDecoder() { };
51 52
52 // Must be called on the main thread. |decodeAsync| and callees must not mo dify any of the 53 // Must be called on the main thread. |decodeAsync| and callees must not mo dify any of the
53 // parameters except |audioData|. They are used to associate this decoding instance with the 54 // parameters except |audioData|. They are used to associate this decoding instance with the
54 // caller to process the decoding appropriately when finished. 55 // caller to process the decoding appropriately when finished.
55 void decodeAsync(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCal lback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolve r* , BaseAudioContext*); 56 void decodeAsync(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCal lback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolve r* , BaseAudioContext*);
56 57
57 private: 58 private:
58 AudioBuffer* createAudioBufferFromAudioBus(AudioBus*); 59 AudioBuffer* createAudioBufferFromAudioBus(AudioBus*);
59 static void decode(DOMArrayBuffer* audioData, float sampleRate, AudioBufferC allback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResol ver*, BaseAudioContext*); 60 static void decodeOnBackgroundThread(DOMArrayBuffer* audioData, float sample Rate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolver*, BaseAudioContext*);
60 static void notifyComplete(DOMArrayBuffer* audioData, AudioBufferCallback* s uccessCallback, AudioBufferCallback* errorCallback, AudioBus*, ScriptPromiseReso lver*, BaseAudioContext*); 61 static void notifyComplete(DOMArrayBuffer* audioData, AudioBufferCallback* s uccessCallback, AudioBufferCallback* errorCallback, AudioBus*, ScriptPromiseReso lver*, BaseAudioContext*);
61
62 std::unique_ptr<WebThread> m_thread;
63 }; 62 };
64 63
65 } // namespace blink 64 } // namespace blink
66 65
67 #endif // AsyncAudioDecoder_h 66 #endif // AsyncAudioDecoder_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698