Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2268403005: Revert of [Presubmit tests] Warn when new source files are not added to GN/GYPi files. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presubmit tests] Warn when new source files are not added to GN/GYPi files. (patchset #3 id:60001 of https://codereview.chromium.org/2252043004/ ) Reason for revert: Reverting ... apparently "warnings" actually cause the presubmit check to fail. This check should probably be upload-only (not commit) so that it can be bypassed, at least until we're sure it's not producing false positives. Original issue's description: > [Presubmit tests] Warn when new source files are not added to GN/GYPi files. > > Add a presubmit check that warns when new source files are > not added to GN or gypi files. > > BUG=112371 > > Committed: https://crrev.com/c4acbcd92229d9635ae0a3dafb65dfc285db0aec > Cr-Commit-Position: refs/heads/master@{#414003} TBR=maksim.sisov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=112371 Committed: https://crrev.com/ccc3b19255107e297fb4d9480de5ff9141402e18 Cr-Commit-Position: refs/heads/master@{#414085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of [Presubmit tests] Warn when new source files are not added to GN/GYPi ...
4 years, 4 months ago (2016-08-24 15:58:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268403005/1
4 years, 4 months ago (2016-08-24 15:58:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 15:59:14 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:01:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccc3b19255107e297fb4d9480de5ff9141402e18
Cr-Commit-Position: refs/heads/master@{#414085}

Powered by Google App Engine
This is Rietveld 408576698