Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2268393002:
[Mac][MD User Menu] Adjusted the vertical position of icon in avatar button (Closed)
|
Created:
4 years, 4 months ago by Jane Modified:
4 years, 4 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac][MD User Menu] Adjusted the vertical position of icon in avatar button
Adjusted the vertical position of the error icon in MD avatar button so
that it looks vertically centered. See first bug.
BUG=636035
BUG=615893
Committed: https://crrev.com/3c21870f967d30e6bd32c1e9c55e82f345a94d53
Cr-Commit-Position: refs/heads/master@{#413918}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Extra { #Messages
Total messages: 19 (14 generated)
Description was changed from ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. BUG=636035 BUG=615893 ========== to ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG=636035 BUG=615893 ==========
janeliulwq@google.com changed reviewers: + groby@chromium.org
Thanks!
LGTM, thank you https://codereview.chromium.org/2268393002/diff/1/chrome/browser/ui/cocoa/pro... File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right): https://codereview.chromium.org/2268393002/diff/1/chrome/browser/ui/cocoa/pro... chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:103: if (!hasError_ || switches::IsMaterialDesignUserMenu()) { I wish we fixed the assets instead of adding more :)
The CQ bit was checked by janeliulwq@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by janeliulwq@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by janeliulwq@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org Link to the patchset: https://codereview.chromium.org/2268393002/#ps20001 (title: "Extra {")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG=636035 BUG=615893 ========== to ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG=636035 BUG=615893 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG=636035 BUG=615893 ========== to ========== [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG=636035 BUG=615893 Committed: https://crrev.com/3c21870f967d30e6bd32c1e9c55e82f345a94d53 Cr-Commit-Position: refs/heads/master@{#413918} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3c21870f967d30e6bd32c1e9c55e82f345a94d53 Cr-Commit-Position: refs/heads/master@{#413918} |
