Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2268363002:
[Asm.js] Prevents assignments to immutables. (Closed)
Description[Asm.js] Prevents assignments to immutables.
Adds a check so that module validation fails if there are any
assignments to immutable identifiers (e.g., module name, module
parameters, stdlib imports.)
BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=640194
Committed: https://crrev.com/a60e1822504f1c87fd067b150354ccb544823bc3
Cr-Commit-Position: refs/heads/master@{#38838}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addresses comments #
Total comments: 2
Patch Set 3 : Addresses comments. #
Messages
Total messages: 28 (16 generated)
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jpp@chromium.org changed reviewers: + bradnelson@chromium.org, mstarzinger@chromium.org
titzer@chromium.org changed reviewers: + titzer@chromium.org
lgtm https://codereview.chromium.org/2268363002/diff/1/test/cctest/asmjs/test-asm-... File test/cctest/asmjs/test-asm-typer.cc (right): https://codereview.chromium.org/2268363002/diff/1/test/cctest/asmjs/test-asm-... test/cctest/asmjs/test-asm-typer.cc:1944: // This issue was triggered because assignment to special symbosl (i.e., the s/assignment to special symbosl/a special symbol/
https://codereview.chromium.org/2268363002/diff/1/test/cctest/asmjs/test-asm-... File test/cctest/asmjs/test-asm-typer.cc (right): https://codereview.chromium.org/2268363002/diff/1/test/cctest/asmjs/test-asm-... test/cctest/asmjs/test-asm-typer.cc:1944: // This issue was triggered because assignment to special symbosl (i.e., the On 2016/08/23 13:58:25, titzer wrote: > s/assignment to special symbosl/a special symbol/ I rephrased slightly differently: intead of "special" I called them "immutable." let me know.
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/23 14:02:36, John wrote: > The CQ bit was checked by mailto:jpp@chromium.org to run a CQ dry run rpa-1a
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm https://codereview.chromium.org/2268363002/diff/20001/src/asmjs/asm-typer.cc File src/asmjs/asm-typer.cc (left): https://codereview.chromium.org/2268363002/diff/20001/src/asmjs/asm-typer.cc#... src/asmjs/asm-typer.cc:1747: DCHECK(target_info->type() != AsmType::None()); Isn't this still a valid check after the mutable check?
The CQ bit was checked by jpp@chromium.org to run a CQ dry run
https://codereview.chromium.org/2268363002/diff/20001/src/asmjs/asm-typer.cc File src/asmjs/asm-typer.cc (left): https://codereview.chromium.org/2268363002/diff/20001/src/asmjs/asm-typer.cc#... src/asmjs/asm-typer.cc:1747: DCHECK(target_info->type() != AsmType::None()); On 2016/08/23 15:56:51, bradn wrote: > Isn't this still a valid check after the mutable check? It is. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bradnelson@google.com
lgtm
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2268363002/#ps40001 (title: "Addresses comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
meant to use this account lgtm
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Asm.js] Prevents assignments to immutables. Adds a check so that module validation fails if there are any assignments to immutable identifiers (e.g., module name, module parameters, stdlib imports.) BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=640194 ========== to ========== [Asm.js] Prevents assignments to immutables. Adds a check so that module validation fails if there are any assignments to immutable identifiers (e.g., module name, module parameters, stdlib imports.) BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=640194 Committed: https://crrev.com/a60e1822504f1c87fd067b150354ccb544823bc3 Cr-Commit-Position: refs/heads/master@{#38838} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a60e1822504f1c87fd067b150354ccb544823bc3 Cr-Commit-Position: refs/heads/master@{#38838} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
