Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2268353004: MD History: fix side nav layout in RTL (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: fix side nav layout in RTL R=tsergeant@chromium.org BUG=640100 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/80d506d4e1869754c9f119a32943658153140571 Cr-Commit-Position: refs/heads/master@{#413896}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.html View 2 chunks +5 lines, -1 line 1 comment Download
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Beam
4 years, 4 months ago (2016-08-23 20:57:12 UTC) #2
tsergeant
Heh: https://codereview.chromium.org/2273563002/ lgtm, but update to BUG=640100 https://codereview.chromium.org/2268353004/diff/1/chrome/browser/resources/md_history/app.html File chrome/browser/resources/md_history/app.html (right): https://codereview.chromium.org/2268353004/diff/1/chrome/browser/resources/md_history/app.html#newcode31 chrome/browser/resources/md_history/app.html:31: * crbug.com/618153. ...
4 years, 4 months ago (2016-08-23 23:07:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268353004/1
4 years, 4 months ago (2016-08-23 23:14:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 23:27:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:28:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80d506d4e1869754c9f119a32943658153140571
Cr-Commit-Position: refs/heads/master@{#413896}

Powered by Google App Engine
This is Rietveld 408576698