Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2268353003: [Mac][MD User Menu] Fixed the accessibility string of profile button (Closed)

Created:
4 years, 4 months ago by Jane
Modified:
4 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][MD User Menu] Fixed the accessibility string of profile button The new profile card button needs an accessibility string since it has no label. The string would be "Edit person, <profile name>" or "Edit person, <profile name>, <email>" for signed in profiles. See first bug. Tested with VoiceOver. BUG=619725 BUG=615893 Committed: https://crrev.com/d7356a6799fe1970f52a499eafb914f66a3fabaf Cr-Commit-Position: refs/heads/master@{#413965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 3 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jane
PTAL, thanks!
4 years, 4 months ago (2016-08-23 14:10:09 UTC) #2
groby-ooo-7-16
LGTM, thanks!
4 years, 4 months ago (2016-08-23 20:52:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268353003/1
4 years, 4 months ago (2016-08-24 03:12:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 03:19:06 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 03:20:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7356a6799fe1970f52a499eafb914f66a3fabaf
Cr-Commit-Position: refs/heads/master@{#413965}

Powered by Google App Engine
This is Rietveld 408576698