Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2268333002: Move scope_uses_super_property_ to DeclarationScope (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move scope_uses_super_property_ to DeclarationScope This flag was only set on receiver scopes (declaration scopes) already. This makes it statically obvious. BUG=v8:5209 Committed: https://crrev.com/287a71525ea6848daa6292ddfc70f26b95f21c30 Cr-Commit-Position: refs/heads/master@{#38828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M src/ast/scopes.h View 5 chunks +7 lines, -7 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 13:00:07 UTC) #2
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 13:30:42 UTC) #4
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 13:31:30 UTC) #6
vogelheim
lgtm
4 years, 4 months ago (2016-08-23 13:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268333002/1
4 years, 4 months ago (2016-08-23 13:48:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 14:18:16 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:18:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/287a71525ea6848daa6292ddfc70f26b95f21c30
Cr-Commit-Position: refs/heads/master@{#38828}

Powered by Google App Engine
This is Rietveld 408576698