Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4370)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2268323003: Initialize RWHV with default bounds rather than only size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed brackets Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index a2d0dfd4ceede0e626ffc0d8c7779cd2c9637ba7..e914ba5da5ff5d7812c01579ecc70b25ee13ad2b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -11,7 +11,7 @@ import android.content.Intent;
import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.Color;
-import android.graphics.Point;
+import android.graphics.Rect;
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
@@ -2564,11 +2564,12 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mContentViewCore.onHide();
}
+ Rect bounds = new Rect();
if (originalWidth == 0 && originalHeight == 0) {
- Point size = ExternalPrerenderHandler.estimateContentSize(
+ bounds = ExternalPrerenderHandler.estimateContentSize(
(Application) getApplicationContext(), false);
- originalWidth = size.x;
- originalHeight = size.y;
+ originalWidth = bounds.right - bounds.left;
+ originalHeight = bounds.bottom - bounds.top;
}
destroyContentViewCore(deleteOldNativeWebContents);
@@ -2580,6 +2581,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
// However, this size fluttering may confuse Blink and rendered result can be broken
// (see http://crbug.com/340987).
newContentViewCore.onSizeChanged(originalWidth, originalHeight, 0, 0);
+ if (!bounds.isEmpty()) {
+ newContentViewCore.onPhysicalBackingSizeChanged(bounds.right, bounds.bottom);
+ }
newContentViewCore.onShow();
setContentViewCore(newContentViewCore);

Powered by Google App Engine
This is Rietveld 408576698