Initialize RWHV with default bounds rather than only size

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include <utility>
 
@@ skipping 366 matching lines @@
 }
 
 void RenderWidgetHostViewAndroid::WasResized() {
   if (delegated_frame_host_ && content_view_core_)
     delegated_frame_host_->UpdateContainerSizeinDIP(
         content_view_core_->GetViewportSizeDip());
   host_->WasResized();
 }
 
 void RenderWidgetHostViewAndroid::SetSize(const gfx::Size& size) {
   // Ignore the given size as only the Java code has the power to

[no sievers, 2016/08/23 21:24:39]

Hmm looks like we don't implement this function correctly and don't call
WasResized(). I wonder why.

[Yusuf, 2016/08/23 21:30:47]

I think until now, we pretty much ignored any setSize or setBounds calls that is
originating from native since CVC was the only source of truth.

   // resize the view on Android.
-  default_size_ = size;
+  default_bounds_ = gfx::Rect(default_bounds_.origin(), size);
 }
 
 void RenderWidgetHostViewAndroid::SetBounds(const gfx::Rect& rect) {
-  SetSize(rect.size());
+  default_bounds_ = rect;
 }
 
 void RenderWidgetHostViewAndroid::GetScaledContentBitmap(
     float scale,
     SkColorType preferred_color_type,
     gfx::Rect src_subrect,
     const ReadbackRequestCallback& result_callback) {
   if (!host_ || host_->is_hidden() || !IsSurfaceAvailableForCopy()) {
     result_callback.Run(SkBitmap(), READBACK_SURFACE_UNAVAILABLE);
     return;
@@ skipping 137 matching lines @@
     return;
   }
   while (locks_on_frame_count_ > 0) {
     UnlockCompositingSurface();
   }
   RunAckCallbacks();
 }
 
 gfx::Rect RenderWidgetHostViewAndroid::GetViewBounds() const {
   if (!content_view_core_)
-    return gfx::Rect(default_size_);
+    return default_bounds_;
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableOSKOverscroll))
     return gfx::Rect(content_view_core_->GetViewSizeWithOSKHidden());
 
   return gfx::Rect(content_view_core_->GetViewSize());
 }
 
 gfx::Size RenderWidgetHostViewAndroid::GetVisibleViewportSize() const {
   if (!content_view_core_)
-    return default_size_;
+    return default_bounds_.size();
 
   return content_view_core_->GetViewSize();
 }
 
 gfx::Size RenderWidgetHostViewAndroid::GetPhysicalBackingSize() const {
   if (!content_view_core_)

[no sievers, 2016/08/23 21:24:39]

missing braces

-    return gfx::Size();
+    if (default_bounds_.IsEmpty()) return gfx::Size();
+    return gfx::Size(default_bounds_.right()
+        * ui::GetScaleFactorForNativeView(GetNativeView()),
+        default_bounds_.bottom()
+        * ui::GetScaleFactorForNativeView(GetNativeView()));
 
   return content_view_core_->GetPhysicalBackingSize();
 }
 
 bool RenderWidgetHostViewAndroid::DoTopControlsShrinkBlinkSize() const {
   // Whether or not Blink's viewport size should be shrunk by the height of the
   // URL-bar.
   return content_view_core_ &&
          content_view_core_->DoTopControlsShrinkBlinkSize();
 }
 
 float RenderWidgetHostViewAndroid::GetTopControlsHeight() const {
   if (!content_view_core_)
-    return 0.f;
+    return default_bounds_.x();
 
   // The height of the top controls.
   return content_view_core_->GetTopControlsHeightDip();
 }
 
 float RenderWidgetHostViewAndroid::GetBottomControlsHeight() const {
   if (!content_view_core_)
     return 0.f;
 
   // The height of the top controls.
@@ skipping 1257 matching lines @@
     case ui::MotionEvent::ACTION_UP:
     case ui::MotionEvent::ACTION_POINTER_UP:
       UMA_HISTOGRAM_CUSTOM_COUNTS("Event.Latency.OS.TOUCH_RELEASED",
                                   delta.InMicroseconds(), 1, 1000000, 50);
     default:
       return;
   }
 }
 
 }  // namespace content