components/autofill/core/common/save_password_progress_logger_unittest.cc - Issue 2268313003: Improvement of password manager logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger_unittest.cc

Issue 2268313003: Improvement of password manager logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/password_manager/core/browser/browser_save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger_unittest.cc

diff --git a/components/autofill/core/common/save_password_progress_logger_unittest.cc b/components/autofill/core/common/save_password_progress_logger_unittest.cc

index 96f2b4ca7c500707547896feb875feda168c7f24..f047183d4145743a0b904353a14072aa6386e1d7 100644

--- a/components/autofill/core/common/save_password_progress_logger_unittest.cc

+++ b/components/autofill/core/common/save_password_progress_logger_unittest.cc

@@ -63,11 +63,11 @@ TEST(SavePasswordProgressLoggerTest, LogPasswordFormElementID) {

TestLogger logger;

PasswordForm form;

const std::string kHTMLInside("Username <script> element");

- const std::string kHTMLInsideExpected("username script element");

+ const std::string kHTMLInsideExpected("Username script element");

const std::string kIPAddressInside("y128.0.0.1Y");

- const std::string kIPAddressInsideExpected("y128 0 0 1y");

+ const std::string kIPAddressInsideExpected("y128 0 0 1Y");

const std::string kSpecialCharsInside("X@#a$%B&*c()D;:e+!x");

- const std::string kSpecialCharsInsideExpected("x a b c d e x");

+ const std::string kSpecialCharsInsideExpected("X a B c D e x");

form.username_element = UTF8ToUTF16(kHTMLInside);

form.password_element = UTF8ToUTF16(kIPAddressInside);

form.new_password_element = UTF8ToUTF16(kSpecialCharsInside);