Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2268303002: Include only stuff you need, part 4: ast, scopes + fallout. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
Reviewers:
Jarin, Toon Verwaest
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 4: ast, scopes + fallout. Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Committed: https://crrev.com/1776fd09faa41325937ea36d9d708352dc16db82 Cr-Commit-Position: refs/heads/master@{#38818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/liveedit.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
marja
verwaest, ptal jarin, ptal, you're the owner of the following: src/compiler/code-generator.h src/compiler/graph-visualizer.cc src/crankshaft/hydrogen.cc src/crankshaft/hydrogen.h
4 years, 4 months ago (2016-08-23 12:06:38 UTC) #4
Jarin
lgtm for the compiler and crankshaft stuff.
4 years, 4 months ago (2016-08-23 12:10:20 UTC) #5
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-23 12:31:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268303002/1
4 years, 4 months ago (2016-08-23 12:32:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 12:35:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 12:35:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1776fd09faa41325937ea36d9d708352dc16db82
Cr-Commit-Position: refs/heads/master@{#38818}

Powered by Google App Engine
This is Rietveld 408576698