Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2268283005: predictors: Refactor the resource_prefetch_predictor database handling. (Closed)

Created:
4 years, 4 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
pasko
CC:
chromium-reviews, shishir+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Refactor the resource_prefetch_predictor database handling. This is a follow-up to crrev.com/2263243002. The ResourceRow object is no longer needed, this removes it. BUG=631966

Patch Set 1 #

Patch Set 2 : , #

Patch Set 3 : . #

Patch Set 4 : . #

Messages

Total messages: 8 (5 generated)
Benoit L
4 years, 3 months ago (2016-08-24 16:09:46 UTC) #3
Benoit L
4 years, 3 months ago (2016-08-25 11:47:40 UTC) #7
pasko
4 years, 3 months ago (2016-08-25 12:33:09 UTC) #8
Discussed offline, a few topics to figure out:

1. do we really need a separate column for url (if not, can handle it in
ResourceData)

2. the formula for score can change, so we should compute it on every read
anyway, then no reason to persist it to disk

3. inheriting from ResourceData and adding methods to backfill score and primary
key would make for a more encapsulated datastructure. Composition is a good
alternative. Worth it?

Powered by Google App Engine
This is Rietveld 408576698