Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2268283004: Stop calling blink::shutdown in content/ tests (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop calling blink::shutdown in content/ tests As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion) and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), there is no reason we have to shut down the renderer gracefully. It's just causing use-after-free bugs and wasting performance. This CL stops calling blink::shutdown in content/ tests. BUG=639244 Committed: https://crrev.com/5ef6c507623ec9b9536f2912bf3fb53244cd0601 Cr-Commit-Position: refs/heads/master@{#414234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
haraken
PTAL. All tests pass. This is the last place blink::shutdown is used. Once I land ...
4 years, 4 months ago (2016-08-24 06:58:01 UTC) #6
jam
lgtm
4 years, 4 months ago (2016-08-24 16:17:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268283004/1
4 years, 4 months ago (2016-08-24 22:49:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 00:56:11 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 00:59:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ef6c507623ec9b9536f2912bf3fb53244cd0601
Cr-Commit-Position: refs/heads/master@{#414234}

Powered by Google App Engine
This is Rietveld 408576698