media: Add External Clear Key content browser test on Android

content/browser/media/encrypted_media_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "build/build_config.h"
 #include "content/browser/media/media_browsertest.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/shell/browser/shell.h"
+
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #include "media/base/media.h"
 #endif
 
 // Available key systems.
 const char kClearKeyKeySystem[] = "org.w3.clearkey";
+const char kExternalClearKeyKeySystem[] = "org.chromium.externalclearkey";

[jrummell, 2016/08/24 20:36:52]

No complaints about unused value if !OS_ANDROID?

[xhwang, 2016/08/24 23:31:03]

Done.

 
 // Supported media types.
 const char kWebMAudioOnly[] = "audio/webm; codecs=\"vorbis\"";
 const char kWebMVideoOnly[] = "video/webm; codecs=\"vp8\"";
 const char kWebMAudioVideo[] = "video/webm; codecs=\"vorbis, vp8\"";
 
 // EME-specific test results and errors.
 const char kEmeKeyError[] = "KEYERROR";
 const char kEmeNotSupportedError[] = "NOTSUPPORTEDERROR";
 
@@ skipping 167 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(EncryptedMediaTest, UnknownKeySystemThrowsException) {
   RunEncryptedMediaTest(kDefaultEmePlayer,
                         "bear-a_enc-a.webm",
                         kWebMAudioOnly,
                         "com.example.foo",
                         MSE,
                         kEmeNotSupportedError);
 }
 
+#if defined(OS_ANDROID)
+// On Android, External Clear Key is supported in shell/ by using mojo CDM
+// with AesDecryptor running in the GPU process.
+// On other platforms, External Clear Key is supported in chrome/, so it is
+// tested in browser_tests.

[jrummell, 2016/08/24 20:36:53]

If this is already supported, why not run it? The other tests are also mostly in
browser_tests, so why not simply run this additional test here?

[xhwang, 2016/08/24 23:31:03]

As discussed offline, ECK on desktop is not supported in content/ so we can't
run it here.

+IN_PROC_BROWSER_TEST_F(EncryptedMediaTest, ExternalClearKeyPlayback) {
+  RunSimpleEncryptedMediaTest("bear-320x240-av_enc-av.webm", kWebMAudioVideo,

[jrummell, 2016/08/24 20:36:52]

The similar ClearKey test checks media::PlatformHasOpusSupport(). Should this
test do that as well?

[xhwang, 2016/08/24 23:31:03]

That check is for opus. I specifically chose a non-opus test content :)

[jrummell, 2016/08/25 00:14:13]

I missed that. I just looked for the previous test that used "av_enc-av.webm",
and didn't see "opus" in the name.

+                              kExternalClearKeyKeySystem, MSE);
+}
+#endif
+
 }  // namespace content