Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Issue 2268273002: Site Settings Desktop: Show the type of cookie in dropdown (instead of url). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Polish Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data_details_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
index 577664adbf2c88e965880cb6af3ddf8f54ddeb88..1bf1018d81c7ef49e0b2cf70fa0678a4b431faa4 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
@@ -157,6 +157,16 @@ Polymer({
}
},
+ getEntryDescription: function(item) {
+ // Frequently there are multiple cookies per site. To avoid showing a list
+ // of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
+ // cookie to differentiate them.
+ if (item.data.type == 'cookie')
+ return item.title;
+
+ return getCookieDataCategoryText(item.data.type, item.data.totalUsage);
+ },
+
/**
* A handler for when the user opts to remove a single cookie.
* @private
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data_details_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698