Site Settings Desktop: Show the type of cookie in dropdown (instead of url).

chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
index 577664adbf2c88e965880cb6af3ddf8f54ddeb88..d537d8c4f937d8e7c0382cf1b051737046ca6efc 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
@@ -157,6 +157,16 @@ Polymer({
     }
   },
 
+  getEntryDescription: function(item) {
+    // Frequently there are multiple cookies per site. To avoid showing a list
+    // of '1 cookie', '1 cookie', ... etc, it is better to show the title of the
+    // cookie to differentiate them.
+    if (item.data.type == 'cookie')
+      return item.title;
+
+    return getCookieDataCategoryText(item.data.type, 0, item.data.totalUsage);

[dschuyler, 2016/08/23 18:53:39]

Suggestion: just preference, but if 
getCookieDataCategoryText is going to have
special handling for 'cookie' in the two 
places it's used, it may make sense to move
the conditional for cookieCount > 1 out of
getCookieDataCategoryText and handle that
case outside of the function. That would 
simplify getCookieDataCategoryText and there 
would be a symmetry in handling special cases 
outside of the function in both cases.

But it's just an opinion/suggestion.

[Finnur, 2016/08/24 11:31:14]

That's reasonable. Done.

+  },
+
   /**
    * A handler for when the user opts to remove a single cookie.
    * @private