Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2268253002: UMA stats for browser/renderer audio rendering buffer size mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UMA fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« media/base/audio_parameters.cc ('K') | « media/shared_memory_support.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1e85229ab2098cb3036c58fc450a568310f3df3b..e72160344c6144da24b5d80ee3f86b05f9041fa4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -21868,6 +21868,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Media.Audio.Render.BufferSizeMismatch">
+ <owner>olka@chromium.org</owner>
+ <summary>
+ Mismatch between the system buffer size the browser side renders audio at
+ and the buffer size it requests from renderer. When equals zero, it means
+ buffer sizes are equal. When positive, the value reflects the average number
+ of extra consecutive render requests issued by browser to renderer
+ (multiplied by 100); any positive values can cause problems for RTC. When
+ negative, it reflects the average number of extra system audio render calls
+ per one request to the renderer (multiplied by 100). Any values those are
Henrik Grunell 2016/08/25 12:52:09 Nit: We had this discussion before :) I believe s/
+ not multiples of 100 mean that from time to time browser skips a call to
+ renderer, which can cause problems for RTC. The fractional part of the
+ mismatch (i.e. the last two digits of the value) indirectly reflect
+ periodicy of the mismatch effect.
+ </summary>
+</histogram>
+
<histogram name="Media.Audio.Render.FramesRequested" units="frames">
<owner>tommi@chromium.org</owner>
<summary>
@@ -97297,6 +97314,14 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="DefaultBrowser.SetDefaultAsyncDuration"/>
</histogram_suffixes>
+<histogram_suffixes name="AudioLatency" separator=".">
+ <suffix name="LatencyExactMs" label="Exact latency in milliseconds"/>
+ <suffix name="LatencyInteractive" label="Interactive latency"/>
+ <suffix name="LatencyRtc" label="RTC latency"/>
+ <suffix name="LatencyPlayback" label="Playback latency"/>
+ <affected-histogram name="Media.Audio.Render.BufferSizeMismatch"/>
+</histogram_suffixes>
+
<histogram_suffixes name="AutofillDataAvailability" separator=".">
<suffix name="WithNoData" label="no autofill data"/>
<suffix name="WithOnlyServerData" label="only server autofill data"/>
« media/base/audio_parameters.cc ('K') | « media/shared_memory_support.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698