content/renderer/media/audio_renderer_mixer_manager.cc - Issue 2268253002: UMA stats for browser/renderer audio rendering buffer size mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 2268253002: UMA stats for browser/renderer audio rendering buffer size mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: passing latency info to browser Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/audio_device_factory.cc ('k') | content/renderer/media/renderer_webaudiodevice_impl.cc » ('j') | media/audio/audio_output_resampler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_renderer_mixer_manager.cc

diff --git a/content/renderer/media/audio_renderer_mixer_manager.cc b/content/renderer/media/audio_renderer_mixer_manager.cc

index c1f82e1ceb6ad6c8b9e97e7012fa322e8c420113..972af05f614ccb8fecee389256b4fa0d860ed3e6 100644

--- a/content/renderer/media/audio_renderer_mixer_manager.cc

+++ b/content/renderer/media/audio_renderer_mixer_manager.cc

@@ -72,9 +72,11 @@ media::AudioParameters GetMixerOutputParams(

// Force to 16-bit output for now since we know that works everywhere;

// ChromeOS does not support other bit depths.

- return media::AudioParameters(input_params.format(),

+ media::AudioParameters params(input_params.format(),

input_params.channel_layout(),

output_sample_rate, 16, output_buffer_size);

+ params.set_latency_tag(latency);

+ return params;

}

void LogMixerUmaHistogram(media::AudioLatency::LatencyType latency, int value) {