Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: media/base/audio_parameters.cc

Issue 2268253002: UMA stats for browser/renderer audio rendering buffer size mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: passing latency info to browser Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/audio_parameters.h" 5 #include "media/base/audio_parameters.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "media/base/limits.h" 8 #include "media/base/limits.h"
9 9
10 namespace media { 10 namespace media {
11 11
12 AudioParameters::AudioParameters() 12 AudioParameters::AudioParameters()
13 : AudioParameters(AUDIO_PCM_LINEAR, CHANNEL_LAYOUT_NONE, 0, 0, 0) {} 13 : AudioParameters(AUDIO_PCM_LINEAR, CHANNEL_LAYOUT_NONE, 0, 0, 0) {}
14 14
15 AudioParameters::AudioParameters(Format format, 15 AudioParameters::AudioParameters(Format format,
16 ChannelLayout channel_layout, 16 ChannelLayout channel_layout,
17 int sample_rate, 17 int sample_rate,
18 int bits_per_sample, 18 int bits_per_sample,
19 int frames_per_buffer) { 19 int frames_per_buffer)
20 : latency_tag_(AudioLatency::LATENCY_COUNT) {
Henrik Grunell 2016/08/23 15:53:19 I don't think an invalid value should be used to s
o1ka 2016/08/23 16:20:56 It would be a pain for IPC
Henrik Grunell 2016/08/24 12:47:15 OK. It's still hacky I think to use the count to i
20 Reset(format, channel_layout, sample_rate, bits_per_sample, 21 Reset(format, channel_layout, sample_rate, bits_per_sample,
21 frames_per_buffer); 22 frames_per_buffer);
22 } 23 }
23 24
24 AudioParameters::~AudioParameters() {} 25 AudioParameters::~AudioParameters() {}
25 26
26 AudioParameters::AudioParameters(const AudioParameters&) = default; 27 AudioParameters::AudioParameters(const AudioParameters&) = default;
27 AudioParameters& AudioParameters::operator=(const AudioParameters&) = default; 28 AudioParameters& AudioParameters::operator=(const AudioParameters&) = default;
28 29
29 void AudioParameters::Reset(Format format, 30 void AudioParameters::Reset(Format format,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 99
99 // static 100 // static
100 AudioParameters AudioParameters::UnavailableDeviceParams() { 101 AudioParameters AudioParameters::UnavailableDeviceParams() {
101 return media::AudioParameters( 102 return media::AudioParameters(
102 media::AudioParameters::AUDIO_FAKE, media::CHANNEL_LAYOUT_STEREO, 103 media::AudioParameters::AUDIO_FAKE, media::CHANNEL_LAYOUT_STEREO,
103 media::AudioParameters::kAudioCDSampleRate, 16, 104 media::AudioParameters::kAudioCDSampleRate, 16,
104 media::AudioParameters::kAudioCDSampleRate / 10); 105 media::AudioParameters::kAudioCDSampleRate / 10);
105 } 106 }
106 107
107 } // namespace media 108 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698