Remove SelectionOption argument of HTMLTextFormControlElement::setSelectionRange().

Remove SelectionOption argument of HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
This CL has no behavior changes.

Committed: https://crrev.com/8ac8545cfbd895104aef2731c974f2e736fc385c
Cr-Commit-Position: refs/heads/master@{#414002}

[tkent, 2016-08-23 09:26:50]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-08-23 09:27:04]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-23 09:27:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-23 11:07:26]

Description was changed from

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
==========

to

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.

This CL has a small behavior change of select().  In 'focus' event handler
triggered
by select(), the element had new selection, but it has the old selection since
this
CL.  The old behavior was compatible with Edge, and the new behavior is
compatible
with Firefox. xxx
==========

[commit-bot: I haz the power, 2016-08-23 11:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 11:19:08]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-23 11:50:03]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 11:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 16:04:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-08-23 21:23:43]

Description was changed from

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.

This CL has a small behavior change of select().  In 'focus' event handler
triggered
by select(), the element had new selection, but it has the old selection since
this
CL.  The old behavior was compatible with Edge, and the new behavior is
compatible
with Firefox. xxx
==========

to

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
This CL has no behavior changes.
==========

[tkent, 2016-08-23 22:53:50]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-08-24 00:46:29]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2016-08-24 00:46:29]

yoichio@, yosin@, would you review this please?

[yosin_UTC9, 2016-08-24 02:04:39]

lgtm

Thanks for cleanup!

[yosin_UTC9, 2016-08-24 02:04:43]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:05:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 05:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 05:27:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-08-24 05:34:10]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-24 05:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 07:05:07]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-08-24 07:07:51]

Description was changed from

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
This CL has no behavior changes.
==========

to

==========
Remove SelectionOption argument of
HTMLTextFormControlElement::setSelectionRange().

We can always use ChangeSelectionIfFocused behavior by updating select()
implementation.
This CL has no behavior changes.

Committed: https://crrev.com/8ac8545cfbd895104aef2731c974f2e736fc385c
Cr-Commit-Position: refs/heads/master@{#414002}
==========

[commit-bot: I haz the power, 2016-08-24 07:07:52]

Patchset 1 (id:??) landed as
https://crrev.com/8ac8545cfbd895104aef2731c974f2e736fc385c
Cr-Commit-Position: refs/heads/master@{#414002}