Fix HandlerLeak lint warning

android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.android.webview.chromium;
 
+import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.graphics.Canvas;
 import android.graphics.Color;
 import android.graphics.Picture;
 import android.net.Uri;
 import android.net.http.SslError;
 import android.os.Build;
@@ skipping 86 matching lines @@
     private WebViewDelegate mWebViewDelegate;
 
     private DownloadListener mDownloadListener;
 
     private Handler mUiThreadHandler;
 
     private static final int NEW_WEBVIEW_CREATED = 100;
 
     private WeakHashMap<AwPermissionRequest, WeakReference<PermissionRequestAdapter>>
             mOngoingPermissionRequests;
+
+    // Suppress the handler leak lint warning because:
+    // 1. the handler does not get GC'ed when there are still pending messages, which does
+    // not happen when there are no delayed messages.
+    // 2. If the app returns true for WebChromeClient#onCreateWindow callback but
+    // does not reply to the message with the WebView instance for the popup, then the
+    // static handler + weak reference pattern will have to deal with the case where the
+    // original webview instance being GC'ed by the time NEW_WEBVIEW_CREATED is sent by the
+    // app. Too much complexity for little gain.
+    @SuppressLint("HandlerLeak")

[boliu, 2016/08/24 21:25:43]

I say don't bother with the comment. it's bound to get out of date next time
someone changes this

Also I think general pattern is annotation after javadoc?

[hush (inactive), 2016/08/30 21:58:17]

Done.

     /**
      * Adapter constructor.
      *
      * @param webView the {@link WebView} instance that this adapter is serving.
      */
     WebViewContentsClientAdapter(WebView webView, Context context,
             WebViewDelegate webViewDelegate) {
         if (webView == null || webViewDelegate == null) {
             throw new IllegalArgumentException("webView or delegate can't be null.");
         }
@@ skipping 1159 matching lines @@
                 mAwPermissionRequest.deny();
             }
         }
 
         @Override
         public void deny() {
             mAwPermissionRequest.deny();
         }
     }
 }