OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "FindBadConstructsAction.h" | 5 #include "FindBadConstructsAction.h" |
6 | 6 |
7 #include "clang/AST/ASTConsumer.h" | 7 #include "clang/AST/ASTConsumer.h" |
8 #include "clang/Frontend/FrontendPluginRegistry.h" | 8 #include "clang/Frontend/FrontendPluginRegistry.h" |
9 | 9 |
10 #include "FindBadConstructsConsumer.h" | 10 #include "FindBadConstructsConsumer.h" |
(...skipping 30 matching lines...) Expand all Loading... |
41 | 41 |
42 bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance, | 42 bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance, |
43 const std::vector<std::string>& args) { | 43 const std::vector<std::string>& args) { |
44 bool parsed = true; | 44 bool parsed = true; |
45 | 45 |
46 for (size_t i = 0; i < args.size() && parsed; ++i) { | 46 for (size_t i = 0; i < args.size() && parsed; ++i) { |
47 if (args[i] == "check-base-classes") { | 47 if (args[i] == "check-base-classes") { |
48 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed. | 48 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed. |
49 options_.check_base_classes = true; | 49 options_.check_base_classes = true; |
50 } else if (args[i] == "enforce-in-pdf") { | 50 } else if (args[i] == "enforce-in-pdf") { |
51 options_.enforce_in_pdf = true; | 51 // TODO(thestig): This is now always on. Remove support for this flag once |
| 52 // the build no longer passes it in. |
52 } else if (args[i] == "enforce-in-thirdparty-webkit") { | 53 } else if (args[i] == "enforce-in-thirdparty-webkit") { |
53 options_.enforce_in_thirdparty_webkit = true; | 54 options_.enforce_in_thirdparty_webkit = true; |
54 } else if (args[i] == "check-enum-last-value") { | 55 } else if (args[i] == "check-enum-last-value") { |
55 // TODO(tsepez): Enable this by default once http://crbug.com/356815 | 56 // TODO(tsepez): Enable this by default once http://crbug.com/356815 |
56 // and http://crbug.com/356816 are fixed. | 57 // and http://crbug.com/356816 are fixed. |
57 options_.check_enum_last_value = true; | 58 options_.check_enum_last_value = true; |
58 } else if (args[i] == "check-templates") { | 59 } else if (args[i] == "check-templates") { |
59 // TODO(thakis): This is now always on. Remove support for this flag once | 60 // TODO(thakis): This is now always on. Remove support for this flag once |
60 // the build no longer passes it in. | 61 // the build no longer passes it in. |
61 } else if (args[i] == "follow-macro-expansion") { | 62 } else if (args[i] == "follow-macro-expansion") { |
(...skipping 14 matching lines...) Expand all Loading... |
76 } | 77 } |
77 | 78 |
78 return parsed; | 79 return parsed; |
79 } | 80 } |
80 | 81 |
81 } // namespace chrome_checker | 82 } // namespace chrome_checker |
82 | 83 |
83 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( | 84 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( |
84 "find-bad-constructs", | 85 "find-bad-constructs", |
85 "Finds bad C++ constructs"); | 86 "Finds bad C++ constructs"); |
OLD | NEW |