Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2268193002: Add new Android JUnit Instrumentation Skip code to python script (Closed)

Created:
4 years, 4 months ago by the real yoland
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new Android JUnit Instrumentation Skip code to python script BUG=640116 Committed: https://crrev.com/eba205fdea8093667b14910301622f4a50002f5e Cr-Commit-Position: refs/heads/master@{#414813}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test for new skip code #

Patch Set 3 : Reorder imports #

Total comments: 2

Patch Set 4 : Remove imports #

Patch Set 5 : Delete empty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/android/pylib/instrumentation/instrumentation_parser.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance_test.py View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
the real yoland
4 years, 4 months ago (2016-08-23 16:09:23 UTC) #2
jbudorick
https://codereview.chromium.org/2268193002/diff/1/build/android/pylib/instrumentation/instrumentation_parser.py File build/android/pylib/instrumentation/instrumentation_parser.py (right): https://codereview.chromium.org/2268193002/diff/1/build/android/pylib/instrumentation/instrumentation_parser.py#newcode13 build/android/pylib/instrumentation/instrumentation_parser.py:13: STATUS_CODE_SKIP = -3 Can you add a test that ...
4 years, 4 months ago (2016-08-24 15:55:23 UTC) #3
the real yoland
https://codereview.chromium.org/2268193002/diff/1/build/android/pylib/instrumentation/instrumentation_parser.py File build/android/pylib/instrumentation/instrumentation_parser.py (right): https://codereview.chromium.org/2268193002/diff/1/build/android/pylib/instrumentation/instrumentation_parser.py#newcode13 build/android/pylib/instrumentation/instrumentation_parser.py:13: STATUS_CODE_SKIP = -3 On 2016/08/24 at 15:55:23, jbudorick wrote: ...
4 years, 4 months ago (2016-08-24 20:24:33 UTC) #4
jbudorick
lgtm w/ nit https://codereview.chromium.org/2268193002/diff/40001/build/android/pylib/instrumentation/instrumentation_test_instance_test.py File build/android/pylib/instrumentation/instrumentation_test_instance_test.py (right): https://codereview.chromium.org/2268193002/diff/40001/build/android/pylib/instrumentation/instrumentation_test_instance_test.py#newcode15 build/android/pylib/instrumentation/instrumentation_test_instance_test.py:15: os.path.join(os.path.dirname(__file__), os.pardir, os.pardir))) nit: You shouldn't ...
4 years, 4 months ago (2016-08-24 20:33:08 UTC) #5
the real yoland
https://codereview.chromium.org/2268193002/diff/40001/build/android/pylib/instrumentation/instrumentation_test_instance_test.py File build/android/pylib/instrumentation/instrumentation_test_instance_test.py (right): https://codereview.chromium.org/2268193002/diff/40001/build/android/pylib/instrumentation/instrumentation_test_instance_test.py#newcode15 build/android/pylib/instrumentation/instrumentation_test_instance_test.py:15: os.path.join(os.path.dirname(__file__), os.pardir, os.pardir))) On 2016/08/24 at 20:33:07, jbudorick wrote: ...
4 years, 3 months ago (2016-08-26 19:53:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268193002/80001
4 years, 3 months ago (2016-08-26 19:53:53 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-08-26 21:34:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:36:00 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/eba205fdea8093667b14910301622f4a50002f5e
Cr-Commit-Position: refs/heads/master@{#414813}

Powered by Google App Engine
This is Rietveld 408576698