Make PendingScript MemoryCoordinatorClient.

third_party/WebKit/Source/core/dom/PendingScript.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 30 matching lines @@
 
 PendingScript::PendingScript(Element* element, ScriptResource* resource)
     : m_watchingForLoad(false)
     , m_element(element)
     , m_integrityFailure(false)
     , m_parserBlockingLoadStartTime(0)
     , m_client(nullptr)
 {
     setScriptResource(resource);
     ThreadState::current()->registerPreFinalizer(this);
+    MemoryCoordinator::instance().registerClient(this);
 }
 
 PendingScript::~PendingScript()
 {
+    MemoryCoordinator::instance().unregisterClient(this);

[haraken, 2016/08/24 06:11:12]

You don't need to (shouldn't) call this. Oilpan's weak processing automatically
removes the client from the hash set.

[tasak, 2016/08/24 07:44:54]

Done.

 }
 
 void PendingScript::dispose()
 {
     if (!m_client)
         return;
     stopWatchingForLoad();
     releaseElementAndClear();
 }
 
@@ skipping 115 matching lines @@
     if (m_streamer)
         m_streamer->notifyAppendData(resource);
 }
 
 DEFINE_TRACE(PendingScript)
 {
     visitor->trace(m_element);
     visitor->trace(m_streamer);
     visitor->trace(m_client);
     ResourceOwner<ScriptResource>::trace(visitor);
+    MemoryCoordinatorClient::trace(visitor);
 }
 
 ScriptSourceCode PendingScript::getSource(const KURL& documentURL, bool& errorOccurred) const
 {
     if (resource()) {
         errorOccurred = resource()->errorOccurred() || m_integrityFailure;
         DCHECK(resource()->isLoaded());
         if (m_streamer && !m_streamer->streamingSuppressed())
             return ScriptSourceCode(m_streamer, resource());
         return ScriptSourceCode(resource());
@@ skipping 20 matching lines @@
 
 bool PendingScript::errorOccurred() const
 {
     if (resource())
         return resource()->errorOccurred();
     if (m_streamer && m_streamer->resource())
         return m_streamer->resource()->errorOccurred();
     return false;
 }
 
+void PendingScript::prepareToSuspend()
+{
+    if (resource() && resource()->isLoaded())

[haraken, 2016/08/24 06:11:12]

Would you help me understand why we need this check?

[tasak, 2016/08/24 07:44:53]

When I chatted with hiroshige@, he said that ScriptStreaming had already
finished when a resource was loaded. So we don't need to do anything when a
script resource is loaded. MemoryCache should take care of loaded resources (or
resource's prepareToSuspend should take care).

[marja, 2016/08/24 09:02:55]

If the resource is loaded we might still be parsing it. Don't you want to cancel
the parsing?

Also, doesn't finishing the parsing then make the upper layers compile and run
the script, or, which part takes care of cancelling / suppressing those actions?

[tasak, 2016/08/24 11:01:03]

In the case, I would like to update ScriptResource (or its base class Resource)
to do some action (if possible, cancel parsing).
i.e.
ScriptResource::prepareToSuspend() { /* cancel parsing? */ }

+        return;
+    if (!m_streamer)
+        return;
+    m_streamer->cancel();
+}
+
 } // namespace blink