Instance-type-related fixes and cleanup.

Instance-type-related fixes and cleanup.

Things got quite a bit out of sync (don't we all love copy-n-paste?):

   * TypeToString didn't handle SLICED_STRING_TYPE,
     SLICED_ASCII_STRING_TYPE, FIXED_DOUBLE_ARRAY_TYPE,
     JS_FUNCTION_PROXY_TYPE and JS_DATE_TYPE.

   * INSTANCE_TYPE_LIST was missing entries for
     SLICED_ASCII_STRING_TYPE, JS_SET_TYPE, and JS_MAP_TYPE.

To improve this maintenance nightmare a little bit, the missing
instance types were added to the INSTANCE_TYPE_LIST macro and this
list is now used via our beloved 2nd order macro technique in
TypeToString. As a side-effect, the strings returned by TypeToString
have a "_TYPE" suffix now, but this doesn't really matter and is a
small price to pay for consistency.

Removed INVALID_TYPE on the way, it had no real use.

R=mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16120

[Michael Starzinger, 2013-08-09 08:20:39]

LGTM (with a nit).

https://codereview.chromium.org/22681004/diff/1/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/22681004/diff/1/src/objects-printer.cc#newcod...
src/objects-printer.cc:514: return "";  // Keep the compiler happy.
nit: Let's return "UNKNOWN" so that the object printer prints something for
corrupted heaps in release mode.

[Sven Panne, 2013-08-09 08:22:52]

Committed patchset #2 manually as r16120 (presubmit successful).

[Sven Panne, 2013-08-09 08:39:02]

https://codereview.chromium.org/22681004/diff/1/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/22681004/diff/1/src/objects-printer.cc#newcod...
src/objects-printer.cc:514: return "";  // Keep the compiler happy.
On 2013/08/09 08:20:39, Michael Starzinger wrote:
> nit: Let's return "UNKNOWN" so that the object printer prints something for
> corrupted heaps in release mode.

Done.