Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2268073004: fix conic path fuzz (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix conic path fuzz The test conic has a very large weight, so it reduces to a pair of lines. Detect this case rather than subdividing the conic so much that the answers are meaningless. R=herb@google.com, reed@google.com BUG=638223 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2268073004 Committed: https://skia.googlesource.com/skia/+/3cebe24682ea8bea3bcab400ff1c79b8e0b12ff0

Patch Set 1 #

Patch Set 2 : add warn unused output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M src/core/SkGeometry.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +16 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
caryclark
4 years, 4 months ago (2016-08-23 13:02:23 UTC) #2
caryclark
4 years, 4 months ago (2016-08-23 14:01:10 UTC) #9
reed1
lgtm
4 years, 4 months ago (2016-08-23 16:34:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268073004/20001
4 years, 4 months ago (2016-08-23 16:39:45 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 16:41:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3cebe24682ea8bea3bcab400ff1c79b8e0b12ff0

Powered by Google App Engine
This is Rietveld 408576698