Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2268073002: MD History: Remove usage of iron-flex-layout from MD History (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Remove usage of iron-flex-layout from MD History iron-flex-layout is most useful for providing the vendor prefixed versions of all the flexbox properties. As we only ever run on Blink, we don't need these. This CL replaces all usage of @apply(--layout-*) mixins in MD History with their native CSS equivalents. This will save a small amount of load time now, and a small amount of vulcanized bundle size when we enable polymer-css-build in https://codereview.chromium.org/2268863002/. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8761d5edaad2934302d7e4726f2c6852f062cde6 Cr-Commit-Position: refs/heads/master@{#414068}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 9 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 5 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
tsergeant
4 years, 4 months ago (2016-08-23 01:32:12 UTC) #4
calamity
lgtm
4 years, 4 months ago (2016-08-24 06:26:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268073002/1
4 years, 4 months ago (2016-08-24 08:41:19 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/md_history/side_bar.html: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-24 10:50:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268073002/20001
4 years, 4 months ago (2016-08-24 11:54:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 14:23:57 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:25:14 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8761d5edaad2934302d7e4726f2c6852f062cde6
Cr-Commit-Position: refs/heads/master@{#414068}

Powered by Google App Engine
This is Rietveld 408576698