[ios] Do not allow WebUI URLs for windows open by DOM.

ios/web/web_state/ui/crw_web_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
 
 #import <objc/runtime.h>
 #include <stddef.h>
@@ skipping 2026 matching lines @@
     [self abortLoad];
 
   DCHECK(!_isHalted);
   // Remove the transient content view.
   [self clearTransientContentView];
 
   const GURL currentURL = [self currentNavigationURL];
   // If it's a chrome URL, but not a native one, create the WebUI instance.
   if (web::GetWebClient()->IsAppSpecificURL(currentURL) &&
       ![_nativeProvider hasControllerForURL:currentURL]) {
-    [self createWebUIForURL:currentURL];
+    web::NavigationItem* item = [self currentNavItem];
+    if (!(item->GetTransitionType() & ui::PAGE_TRANSITION_TYPED) &&
+        self.sessionController.openedByDOM) {
+      // WebUI URLs can not be open By DOM to prevent cross-site scripting as

[Jackie Quinn, 2016/08/23 02:23:05]

s/open By/opened by

[Eugene But (OOO till 7-30), 2016/08/23 17:41:02]

Done.

+      // they have increased power. The only exception is when the user has

[Jackie Quinn, 2016/08/23 02:23:05]

Maybe "WebUI URLs may only be opened when the user types in the URL"

Also does that cover the bookmarked WebUI URL case?

[Eugene But (OOO till 7-30), 2016/08/23 17:41:02]

Good catch. Added bookmarks handling (which also accounts for history) and
updated the comment.

+      // typed URL in.
+      [[self sessionController] discardNonCommittedEntries];
+      return;
+    } else {
+      [self createWebUIForURL:currentURL];
+    }
   }
 
   // Loading a new url, must check here if it's a native chrome URL and
   // replace the appropriate view if so, or transition back to a web view from
   // a native view.
   if ([self shouldLoadURLInNativeView:currentURL]) {
     [self loadCurrentURLInNativeView];
   } else {
     [self loadCurrentURLInWebView];
   }
@@ skipping 3604 matching lines @@
   }
 
   return web::WEB_VIEW_DOCUMENT_TYPE_GENERIC;
 }
 
 - (NSString*)refererFromNavigationAction:(WKNavigationAction*)action {
   return [action.request valueForHTTPHeaderField:@"Referer"];
 }
 
 @end