Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: media/base/pipeline_impl_unittest.cc

Issue 2267963002: Add support for cancellation of demuxer reads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add tests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/blink/multibuffer_data_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl_unittest.cc
diff --git a/media/base/pipeline_impl_unittest.cc b/media/base/pipeline_impl_unittest.cc
index f0f2e8d0f1b3e94bc1756e7ff639f8201f1d12f6..942d5432990fe651525d21e341862c2e9143e1b7 100644
--- a/media/base/pipeline_impl_unittest.cc
+++ b/media/base/pipeline_impl_unittest.cc
@@ -231,6 +231,7 @@ class PipelineImplTest : public ::testing::Test {
FakeTextTrackStream* text_stream() { return text_stream_.get(); }
void ExpectSeek(const base::TimeDelta& seek_time, bool underflowed) {
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(*demuxer_, Seek(seek_time, _))
.WillOnce(RunCallback<1>(PIPELINE_OK));
@@ -256,12 +257,8 @@ class PipelineImplTest : public ::testing::Test {
}
void ExpectSuspend() {
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(*renderer_, SetPlaybackRate(0));
- EXPECT_CALL(*renderer_, Flush(_))
- .WillOnce(
- DoAll(SetBufferingState(&renderer_client_, BUFFERING_HAVE_NOTHING),
- RunClosure<0>()));
- EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
EXPECT_CALL(callbacks_, OnSuspend(PIPELINE_OK));
}
@@ -695,6 +692,7 @@ TEST_F(PipelineImplTest, ErrorDuringSeek) {
DoAll(SetBufferingState(&renderer_client_, BUFFERING_HAVE_NOTHING),
RunClosure<0>()));
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(*demuxer_, Seek(seek_time, _))
.WillOnce(RunCallback<1>(PIPELINE_ERROR_READ));
EXPECT_CALL(*demuxer_, Stop());
@@ -748,6 +746,7 @@ TEST_F(PipelineImplTest, NoMessageDuringTearDownFromError) {
RunClosure<0>()));
EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(*demuxer_, Seek(seek_time, _))
.WillOnce(RunCallback<1>(PIPELINE_ERROR_READ));
EXPECT_CALL(*demuxer_, Stop());
@@ -929,6 +928,7 @@ class PipelineTeardownTest : public PipelineImplTest {
void DoSeek(TeardownState state, StopOrError stop_or_error) {
SetSeekExpectations(state, stop_or_error);
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(*demuxer_, Stop());
pipeline_->Seek(
@@ -1002,12 +1002,8 @@ class PipelineTeardownTest : public PipelineImplTest {
void SetSuspendExpectations(TeardownState state, StopOrError stop_or_error) {
EXPECT_CALL(*renderer_, SetPlaybackRate(0));
- EXPECT_CALL(callbacks_, OnBufferingStateChange(BUFFERING_HAVE_NOTHING));
+ EXPECT_CALL(*demuxer_, AbortPendingReads());
EXPECT_CALL(callbacks_, OnSuspend(PIPELINE_OK));
- EXPECT_CALL(*renderer_, Flush(_))
- .WillOnce(
- DoAll(SetBufferingState(&renderer_client_, BUFFERING_HAVE_NOTHING),
- RunClosure<0>()));
if (state == kResuming) {
if (stop_or_error == kStop) {
EXPECT_CALL(*demuxer_, Seek(_, _))
« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/blink/multibuffer_data_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698