Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2267913003: Fixup building with PDFium XFA enabled. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixup building with PDFium XFA enabled. The SetScrollPosition needed to have the =0 removed and made an override. The use of PDF_USE_XFA is outdated, changed to PDF_ENABLE_XFA. Committed: https://crrev.com/b0d978f4e95a2c09335059acbab4b92570381942 Cr-Commit-Position: refs/heads/master@{#413596}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M pdf/pdf_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.h View 3 chunks +4 lines, -4 lines 1 comment Download
M pdf/pdfium/pdfium_engine.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dsinclair
PTAL.
4 years, 4 months ago (2016-08-22 21:30:04 UTC) #3
Lei Zhang
lgtm if this works for you. https://codereview.chromium.org/2267913003/diff/1/pdf/pdfium/pdfium_engine.h File pdf/pdfium/pdfium_engine.h (left): https://codereview.chromium.org/2267913003/diff/1/pdf/pdfium/pdfium_engine.h#oldcode108 pdf/pdfium/pdfium_engine.h:108: virtual void SetScrollPosition(const ...
4 years, 4 months ago (2016-08-22 21:32:08 UTC) #5
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-23 00:03:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267913003/1
4 years, 4 months ago (2016-08-23 00:08:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 00:16:51 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:19:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0d978f4e95a2c09335059acbab4b92570381942
Cr-Commit-Position: refs/heads/master@{#413596}

Powered by Google App Engine
This is Rietveld 408576698