Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2267893002: Fix for 'Extract Local' in an expression function body. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for 'Extract Local' in an expression function body. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/424cb8d9a4013ea70d3e2111392177a2f5f7b81b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 3 chunks +12 lines, -5 lines 2 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 3 chunks +42 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-22 18:47:24 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2267893002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart File pkg/analysis_server/lib/src/services/refactoring/extract_local.dart (right): https://codereview.chromium.org/2267893002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart#newcode312 pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:312: 'Expression inside a function must be selected ' ...
4 years, 4 months ago (2016-08-22 18:54:38 UTC) #2
scheglov
https://codereview.chromium.org/2267893002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart File pkg/analysis_server/lib/src/services/refactoring/extract_local.dart (right): https://codereview.chromium.org/2267893002/diff/1/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart#newcode312 pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:312: 'Expression inside a function must be selected ' On ...
4 years, 4 months ago (2016-08-22 18:57:44 UTC) #3
scheglov
4 years, 4 months ago (2016-08-22 18:58:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
424cb8d9a4013ea70d3e2111392177a2f5f7b81b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698