Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2267863002: Converted Observatory ports-page element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak, Cutch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -96 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +17 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_ref_wrapper.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref_wrapper.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/object_common_wrapper.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/ports.dart View 1 1 chunk +133 lines, -18 lines 0 comments Download
D runtime/observatory/lib/src/elements/ports.html View 1 chunk +0 lines, -42 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/objects/ports.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/repositories/ports.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/inbound_references.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/instance.dart View 1 chunk +5 lines, -4 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/ports.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/ports.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/instance.dart View 2 chunks +4 lines, -3 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/ports.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/ports/element_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/ports/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-22 16:40:43 UTC) #2
Cutch
lgtm https://codereview.chromium.org/2267863002/diff/1/runtime/observatory/lib/src/elements/ports.dart File runtime/observatory/lib/src/elements/ports.dart (right): https://codereview.chromium.org/2267863002/diff/1/runtime/observatory/lib/src/elements/ports.dart#newcode24 runtime/observatory/lib/src/elements/ports.dart:24: dependencies: const [ indentation
4 years, 4 months ago (2016-08-22 16:45:04 UTC) #3
cbernaschina
https://codereview.chromium.org/2267863002/diff/1/runtime/observatory/lib/src/elements/ports.dart File runtime/observatory/lib/src/elements/ports.dart (right): https://codereview.chromium.org/2267863002/diff/1/runtime/observatory/lib/src/elements/ports.dart#newcode24 runtime/observatory/lib/src/elements/ports.dart:24: dependencies: const [ On 2016/08/22 16:45:04, Cutch wrote: > ...
4 years, 4 months ago (2016-08-22 16:46:54 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-22 16:47:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c6fdc01b91b1037ae123f3643148d9124e1b96fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698