Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2267813002: [devil] Add device provisioning logic to devil. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+893 lines, -42 lines) Patch
M devil/devil/android/sdk/adb_wrapper.py View 1 chunk +2 lines, -0 lines 0 comments Download
A devil/devil/android/settings.py View 1 chunk +275 lines, -0 lines 0 comments Download
M devil/devil/android/tools/device_recovery.py View 1 chunk +4 lines, -14 lines 0 comments Download
M devil/devil/android/tools/device_status.py View 1 chunk +4 lines, -14 lines 0 comments Download
A devil/devil/android/tools/provision_devices.py View 1 chunk +578 lines, -0 lines 0 comments Download
M devil/devil/android/tools/script_common.py View 1 chunk +4 lines, -3 lines 0 comments Download
M devil/devil/devil_env.py View 1 chunk +26 lines, -11 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
jbudorick
4 years, 4 months ago (2016-08-22 15:17:49 UTC) #2
rnephew (Reviews Here)
lgtm despite the slight feature creep :P https://codereview.chromium.org/2267813002/diff/1/devil/devil/devil_env.py File devil/devil/devil_env.py (right): https://codereview.chromium.org/2267813002/diff/1/devil/devil/devil_env.py#newcode51 devil/devil/devil_env.py:51: return { ...
4 years, 4 months ago (2016-08-22 15:36:17 UTC) #3
jbudorick
On 2016/08/22 15:36:17, rnephew (Reviews Here) wrote: > lgtm despite the slight feature creep :P ...
4 years, 4 months ago (2016-08-22 15:36:40 UTC) #4
rnephew (Reviews Here)
On 2016/08/22 15:36:40, jbudorick wrote: > On 2016/08/22 15:36:17, rnephew (Reviews Here) wrote: > > ...
4 years, 4 months ago (2016-08-22 15:38:26 UTC) #5
jbudorick
On 2016/08/22 15:38:26, rnephew (Reviews Here) wrote: > On 2016/08/22 15:36:40, jbudorick wrote: > > ...
4 years, 4 months ago (2016-08-22 15:39:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267813002/1
4 years, 4 months ago (2016-08-22 15:39:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/4310)
4 years, 4 months ago (2016-08-22 16:20:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267813002/1
4 years, 4 months ago (2016-08-22 17:16:30 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:54:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698