Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/parsing/preparser.cc

Issue 2267783002: [parser] Clean up (pre)parser traits (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@nickie-2267663002-crtp
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/preparser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.cc
diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc
index 45df9d8424ef2833ffae1d44712f1cf397b04575..166b5a086691f0d82c2a1a4f552b663cf2688b0a 100644
--- a/src/parsing/preparser.cc
+++ b/src/parsing/preparser.cc
@@ -94,20 +94,6 @@ PreParserExpression ParserBaseTraits<PreParser>::ExpressionFromString(
return PreParserExpression::StringLiteral();
}
-PreParserExpression ParserBaseTraits<PreParser>::ParseV8Intrinsic(bool* ok) {
- return delegate()->ParseV8Intrinsic(ok);
-}
-
-PreParserExpression ParserBaseTraits<PreParser>::ParseFunctionLiteral(
- PreParserIdentifier name, Scanner::Location function_name_location,
- FunctionNameValidity function_name_validity, FunctionKind kind,
- int function_token_position, FunctionLiteral::FunctionType type,
- LanguageMode language_mode, bool* ok) {
- return delegate()->ParseFunctionLiteral(
- name, function_name_location, function_name_validity, kind,
- function_token_position, type, language_mode, ok);
-}
-
PreParser::PreParseResult PreParser::PreParseLazyFunction(
LanguageMode language_mode, FunctionKind kind, bool has_simple_parameters,
bool parsing_module, ParserRecorder* log, Scanner::BookmarkScope* bookmark,
@@ -148,14 +134,6 @@ PreParser::PreParseResult PreParser::PreParseLazyFunction(
return kPreParseSuccess;
}
-PreParserExpression ParserBaseTraits<PreParser>::ParseClassLiteral(
- Type::ExpressionClassifier* classifier, PreParserIdentifier name,
- Scanner::Location class_name_location, bool name_is_strict_reserved,
- int pos, bool* ok) {
- return delegate()->ParseClassLiteral(classifier, name, class_name_location,
- name_is_strict_reserved, pos, ok);
-}
-
// Preparsing checks a JavaScript program and emits preparse-data that helps
// a later parsing to be faster.
@@ -1274,14 +1252,13 @@ PreParserExpression PreParser::ParseDoExpression(bool* ok) {
return PreParserExpression::Default();
}
-void ParserBaseTraits<PreParser>::ParseAsyncArrowSingleExpressionBody(
+void PreParser::ParseAsyncArrowSingleExpressionBody(
PreParserStatementList body, bool accept_IN,
- Type::ExpressionClassifier* classifier, int pos, bool* ok) {
- Scope* scope = delegate()->scope();
- scope->ForceContextAllocation();
+ ExpressionClassifier* classifier, int pos, bool* ok) {
+ scope()->ForceContextAllocation();
- PreParserExpression return_value = delegate()->ParseAssignmentExpression(
- accept_IN, classifier, CHECK_OK_CUSTOM(Void));
+ PreParserExpression return_value =
+ ParseAssignmentExpression(accept_IN, classifier, CHECK_OK_CUSTOM(Void));
body->Add(PreParserStatement::ExpressionStatement(return_value), zone());
}
« no previous file with comments | « src/parsing/preparser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698