Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2267753002: Make lsan and tsan suppressions files overridable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 40ffb94d09885f6b6ed056860db472e0bc186bfe..a2334f145a5063e4c5cab5361b36a9609b1b0edf 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -2,7 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6236.
kjellander_chromium 2016/08/22 14:59:21 Remove our bug refererence.
+import("//build_overrides/build.gni")
+
declare_args() {
+ #
kjellander_chromium 2016/08/22 14:59:21 Please add comments.
+ lsan_suppressions_file = lsan_suppressions_file_override
kjellander_chromium 2016/08/22 14:59:21 I found this pattern confusing, is it really neede
Dirk Pranke 2016/08/22 17:21:50 You would only need this if you need to set the v
kjellander_chromium 2016/08/22 21:00:51 Ah, now I remember that regarding the Mac SDK vers
+
+ #
+ tsan_suppressions_file = tsan_suppressions_file_override
+
# Compile for Address Sanitizer to find memory bugs.
is_asan = false

Powered by Google App Engine
This is Rietveld 408576698