build_overrides/build.gni - Issue 2267753002: Make lsan and tsan suppressions files overridable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/build.gni

Issue 2267753002: Make lsan and tsan suppressions files overridable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the variables to build/config/sanitizers/BUILD.gn. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.	5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.

6 # Some WebRTC targets require the 10.7 deployment version of the Mac SDK	6 # Some WebRTC targets require the 10.7 deployment version of the Mac SDK

7 # and a 10.11 min SDK, but those targets are only used in non-Chromium	7 # and a 10.11 min SDK, but those targets are only used in non-Chromium

8 # builds. We can remove this when Chromium drops 10.6 support and also	8 # builds. We can remove this when Chromium drops 10.6 support and also

9 # requires 10.7.	9 # requires 10.7.

10 mac_sdk_min_build_override = "10.10"	10 mac_sdk_min_build_override = "10.10"

11 mac_deployment_target_build_override = "10.7"	11 mac_deployment_target_build_override = "10.7"

12	12

13 # Variable that can be used to support multiple build scenarios, like having	13 # Variable that can be used to support multiple build scenarios, like having

14 # Chromium specific targets in a client project's GN file etc.	14 # Chromium specific targets in a client project's GN file etc.

15 build_with_chromium = true	15 build_with_chromium = true

16	16

17 # Uncomment these to specify a different NDK location and version in	17 # Uncomment these to specify a different NDK location and version in

18 # non-Chromium builds.	18 # non-Chromium builds.

19 # default_android_ndk_root = "//third_party/android_tools/ndk"	19 # default_android_ndk_root = "//third_party/android_tools/ndk"

20 # default_android_ndk_version = "r10e"	20 # default_android_ndk_version = "r10e"

21	21

22 # Some non-Chromium builds don't support building java targets.	22 # Some non-Chromium builds don't support building java targets.

23 enable_java_templates = true	23 enable_java_templates = true

	24

	25 # Allows different projects to specify their own suppressions files.
	Michael Achenbach 2016/08/30 11:42:47 Would be nicer if there were default values in cas Would be nicer if there were default values in case these values are not overridden. A change like this breaks downstream projects, if not also there these three values are provided. No action required this time. V8 sanitizers already broke and I'll add the values in V8...
	26 asan_suppressions_file = "//build/sanitizers/asan_suppressions.cc"

	27 lsan_suppressions_file = "//build/sanitizers/lsan_suppressions.cc"

	28 tsan_suppressions_file = "//build/sanitizers/tsan_suppressions.cc"

OLD	NEW