Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2267753002: Make lsan and tsan suppressions files overridable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6236.
kjellander_chromium 2016/08/22 14:59:21 Remove our bug refererence.
6 import("//build_overrides/build.gni")
7
5 declare_args() { 8 declare_args() {
9 #
kjellander_chromium 2016/08/22 14:59:21 Please add comments.
10 lsan_suppressions_file = lsan_suppressions_file_override
kjellander_chromium 2016/08/22 14:59:21 I found this pattern confusing, is it really neede
Dirk Pranke 2016/08/22 17:21:50 You would only need this if you need to set the v
kjellander_chromium 2016/08/22 21:00:51 Ah, now I remember that regarding the Mac SDK vers
11
12 #
13 tsan_suppressions_file = tsan_suppressions_file_override
14
6 # Compile for Address Sanitizer to find memory bugs. 15 # Compile for Address Sanitizer to find memory bugs.
7 is_asan = false 16 is_asan = false
8 17
9 # Compile for Leak Sanitizer to find leaks. 18 # Compile for Leak Sanitizer to find leaks.
10 is_lsan = false 19 is_lsan = false
11 20
12 # Compile for Memory Sanitizer to find uninitialized reads. 21 # Compile for Memory Sanitizer to find uninitialized reads.
13 is_msan = false 22 is_msan = false
14 23
15 # Compile for Thread Sanitizer to find threading bugs. 24 # Compile for Thread Sanitizer to find threading bugs.
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 # this condition. We may also be able to find another way to enable your case 176 # this condition. We may also be able to find another way to enable your case
168 # without having people accidentally get broken builds by compiling an 177 # without having people accidentally get broken builds by compiling an
169 # unsupported or unadvisable configurations. 178 # unsupported or unadvisable configurations.
170 # 179 #
171 # For one-off testing, just comment this assertion out. 180 # For one-off testing, just comment this assertion out.
172 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr), 181 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
173 "Sanitizers should generally be used in release (set is_debug=false).") 182 "Sanitizers should generally be used in release (set is_debug=false).")
174 183
175 assert(!is_msan || (is_linux && current_cpu == "x64"), 184 assert(!is_msan || (is_linux && current_cpu == "x64"),
176 "MSan currently only works on 64-bit Linux and ChromeOS builds.") 185 "MSan currently only works on 64-bit Linux and ChromeOS builds.")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698