Make lsan and tsan suppressions files overridable.

build/config/sanitizers/sanitizers.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6236.

[kjellander_chromium, 2016/08/22 14:59:21]

Remove our bug refererence.

+import("//build_overrides/build.gni")
+
 declare_args() {
+  #

[kjellander_chromium, 2016/08/22 14:59:21]

Please add comments.

+  lsan_suppressions_file = lsan_suppressions_file_override

[kjellander_chromium, 2016/08/22 14:59:21]

I found this pattern confusing, is it really needed? I understand Edward took it
from https://cs.chromium.org/chromium/src/build/config/mac/mac_sdk.gni though.

[Dirk Pranke, 2016/08/22 17:21:50]

You would only need this if you  need to set the value differently per-repo and
*also* want to be able to change the value in an args.gn file.

Most overrides only need one or the other. Given that this isn't a declare_arg()
value in chromium, it seems unlikely that it needs to be a declare_arg() in
webrtc as well?

[kjellander_chromium, 2016/08/22 21:00:51]

Ah, now I remember that regarding the Mac SDK version.

Edward: just remove the changes in this file and include
import("//build_overrides/build.gni") straight from
	build/config/sanitizers/BUILD.gn then.

+
+  #
+  tsan_suppressions_file = tsan_suppressions_file_override
+
   # Compile for Address Sanitizer to find memory bugs.
   is_asan = false
 
   # Compile for Leak Sanitizer to find leaks.
   is_lsan = false
 
   # Compile for Memory Sanitizer to find uninitialized reads.
   is_msan = false
 
   # Compile for Thread Sanitizer to find threading bugs.
@@ skipping 151 matching lines @@
 # this condition. We may also be able to find another way to enable your case
 # without having people accidentally get broken builds by compiling an
 # unsupported or unadvisable configurations.
 #
 # For one-off testing, just comment this assertion out.
 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
        "Sanitizers should generally be used in release (set is_debug=false).")
 
 assert(!is_msan || (is_linux && current_cpu == "x64"),
        "MSan currently only works on 64-bit Linux and ChromeOS builds.")