Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: test/cctest/test-compiler.cc

Issue 2267693002: [interpreter] Allow mixed stacks if bytecode is preserved. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Adapt test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler.cc ('K') | « src/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index 68cea9bf522d5e396e728ede7148796bb30ddfb4..c0f6034ead5b5e71f4af13120060d9ca62b6fd74 100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -800,7 +800,11 @@ TEST(IgnitionBaselineOnReturn) {
"};\n"
"return_val = f();\n"
"is_baseline_after_return = IsBaselineCompiled(f);\n");
- CHECK_EQ(false, GetGlobalProperty("is_baseline_in_function")->BooleanValue());
+ // TODO(4280): Remove this entire test once --ignition-preserve-bytecode is
+ // the default and the flag is removed. This test doesn't provide benefit any
+ // longer once {InterpreterActivationsFinder} is gone.
+ bool base = FLAG_ignition_preserve_bytecode;
rmcilroy 2016/08/22 15:33:03 just do: "if (FLAG_ignition_preserve_bytecode) ret
Michael Starzinger 2016/08/22 15:44:23 Done.
+ CHECK_EQ(base, GetGlobalProperty("is_baseline_in_function")->BooleanValue());
CHECK_EQ(true, GetGlobalProperty("is_baseline_after_return")->BooleanValue());
CHECK_EQ(1234.0, GetGlobalProperty("return_val")->Number());
}
« src/compiler.cc ('K') | « src/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698