Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2267683002: Force eager compilation on closure scopes only (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Force eager compilation on closure scopes only In theory the flag could otherwise be set on a blockscope that might be finalized (removed) before PropagateScopeInfo can propagate the flag around. In that case we'd lose the flag. BUG=v8:5209 Committed: https://crrev.com/d8bc37585364792baa2a80dbe23da58765b6ecaa Cr-Commit-Position: refs/heads/master@{#38781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/parsing/parser.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-22 11:48:09 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-22 11:56:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267683002/1
4 years, 4 months ago (2016-08-22 12:09:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 12:32:28 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 12:32:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8bc37585364792baa2a80dbe23da58765b6ecaa
Cr-Commit-Position: refs/heads/master@{#38781}

Powered by Google App Engine
This is Rietveld 408576698