third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h - Issue 2267653005: Resolving drawImage issue with canvases that contain bitmap images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 2267653005: Resolving drawImage issue with canvases that contain bitmap images (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h » ('j') | third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

index 178bddbc54231d730fd04ce1cc3654523d8fae9b..16a4302a6e39c6218c2a81288a30309022308128 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

@@ -127,6 +127,7 @@ public:

// ImageBitmap-specific interface

virtual bool paint(GraphicsContext&, const IntRect&) { return false; }

+ virtual Image* getImage() const { return nullptr; }

Justin Novosad 2016/08/22 19:42:25 Image is a ref counted type. You should not be ret

zakerinasab 2016/08/22 19:55:50 Done.

bool wouldTaintOrigin(CanvasImageSource*, SecurityOrigin* = nullptr);

void didMoveToNewDocument(Document*);