telemetry/telemetry/internal/platform/platform_backend.py - Issue 2267613002: Revert "[telemetry] Wire TsProxy through telemetry's network stack."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/platform_backend.py

Issue 2267613002: Revert "[telemetry] Wire TsProxy through telemetry's network stack." (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/network_controller_backend_unittest.py ('k') | telemetry/telemetry/internal/util/ts_proxy_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/platform_backend.py

diff --git a/telemetry/telemetry/internal/platform/platform_backend.py b/telemetry/telemetry/internal/platform/platform_backend.py

index 2aead5b48978141ab22865ba15217f2408f602fe..aedd6ad44aea81508bb10aed8228e6db4383ceee 100644

--- a/telemetry/telemetry/internal/platform/platform_backend.py

+++ b/telemetry/telemetry/internal/platform/platform_backend.py

@@ -85,9 +85,6 @@ class PlatformBackend(object):

self._forwarder_factory = do_nothing_forwarder.DoNothingForwarderFactory()

return self._forwarder_factory

- def GetPortPairForForwarding(self, local_port):

- return forwarders.PortPair(local_port=local_port, remote_port=local_port)

def GetRemotePort(self, port):

return port

@@ -106,6 +103,13 @@ class PlatformBackend(object):

self._running_browser_backends.discard(browser_backend)

+ def GetWprPortPairs(self):

+ """Return suitable port pairs to be used for web page replay."""

+ return forwarders.PortPairs(

+ http=forwarders.PortPair(0, 0),

+ https=forwarders.PortPair(0, 0),

+ dns=None)

def IsDisplayTracingSupported(self):

return False