Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2267603002: Revert of QUIC - Race Cert Verification with host resolution if certs are (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Race Cert Verification with host resolution if certs are (patchset #11 id:230001 of https://codereview.chromium.org/2120703003/ ) Reason for revert: Causes crashes crbug.com/639519 Original issue's description: > QUIC - Race Cert Verification with host resolution if certs are > availiable when race_cert_verification network session param is enabled. > > This experiment is not enabled in chromium. > > R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, > TBR=eroman@chromium.org (for net-internals changes) > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/d073dd2ac386ae7893f03cd7659abb66f045e5fa > Cr-Commit-Position: refs/heads/master@{#409701} TBR=eroman@chromium.org,mef@chromium.org,rtenneti@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -502 lines) Patch
M chrome/browser/resources/net_internals/quic_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_network_session.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 3 chunks +0 lines, -4 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.cc View 1 9 chunks +23 lines, -126 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium_test.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 7 chunks +0 lines, -18 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 21 chunks +30 lines, -142 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 5 chunks +4 lines, -68 lines 0 comments Download
M net/quic/core/crypto/proof_verifier.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 5 chunks +2 lines, -37 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Ryan Hamilton
Created Revert of QUIC - Race Cert Verification with host resolution if certs are
4 years, 4 months ago (2016-08-21 20:50:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267603002/1
4 years, 4 months ago (2016-08-21 20:50:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/55772) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-21 20:51:42 UTC) #5
Ryan Hamilton
PTAL: I think the original CL is causing crashes, so reverting. (But it landed a ...
4 years, 4 months ago (2016-08-22 16:48:51 UTC) #11
ramant (doing other things)
lgtm Thanks much Ryan for the revert.
4 years, 4 months ago (2016-08-22 16:52:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267603002/270001
4 years, 4 months ago (2016-08-22 18:49:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/243167)
4 years, 4 months ago (2016-08-22 18:58:00 UTC) #16
Ryan Hamilton
4 years, 4 months ago (2016-08-22 19:27:19 UTC) #17
On 2016/08/22 16:52:51, ramant wrote:
> lgtm
> 
> Thanks much Ryan for the revert.

As discussed offline, this CL is not the actual cause so i'll abandon this CL.
Sorry for the hassle.

Powered by Google App Engine
This is Rietveld 408576698