Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2267593002: Add a gradient edge optimization test (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -32 lines) Patch
M tests/GradientTest.cpp View 1 5 chunks +117 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
f(malita)
While working on this, I realized that we are always just adjusting the array start/stop ...
4 years, 4 months ago (2016-08-21 18:14:43 UTC) #2
reed1
https://codereview.chromium.org/2267593002/diff/1/tests/GradientTest.cpp File tests/GradientTest.cpp (right): https://codereview.chromium.org/2267593002/diff/1/tests/GradientTest.cpp#newcode192 tests/GradientTest.cpp:192: static void TestGradientEdgeOptimization(skiatest::Reporter* reporter) { I don't understand why ...
4 years, 4 months ago (2016-08-22 11:53:29 UTC) #7
reed1
lgtm
4 years, 4 months ago (2016-08-22 11:53:43 UTC) #8
f(malita)
https://codereview.chromium.org/2267593002/diff/1/tests/GradientTest.cpp File tests/GradientTest.cpp (right): https://codereview.chromium.org/2267593002/diff/1/tests/GradientTest.cpp#newcode192 tests/GradientTest.cpp:192: static void TestGradientEdgeOptimization(skiatest::Reporter* reporter) { On 2016/08/22 11:53:28, reed1 ...
4 years, 4 months ago (2016-08-22 13:05:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267593002/20001
4 years, 4 months ago (2016-08-22 13:05:53 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 13:22:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5122967e60915d2b4322bbd059f6f641c11f5216

Powered by Google App Engine
This is Rietveld 408576698