Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2267543002: Fix patterns in CFI blacklist. (Closed)

Created:
4 years, 4 months ago by krasin
Modified:
4 years, 4 months ago
Reviewers:
krasin1, kcc2
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix patterns in CFI blacklist. The comparison happens on mangled names. Of course, there's no double colon is there. BUG=634139 TBR=kcc@chromium.org Committed: https://crrev.com/06739364e2093d1dd489d2a232edac0402354f1d Cr-Commit-Position: refs/heads/master@{#413329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -110 lines) Patch
M tools/cfi/blacklist.txt View 2 chunks +110 lines, -110 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267543002/1
4 years, 4 months ago (2016-08-20 08:53:34 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-20 08:53:35 UTC) #4
krasin1
self LGTM (but Kostya, please, approve this too)
4 years, 4 months ago (2016-08-20 08:56:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267543002/1
4 years, 4 months ago (2016-08-20 08:56:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 09:37:00 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/06739364e2093d1dd489d2a232edac0402354f1d Cr-Commit-Position: refs/heads/master@{#413329}
4 years, 4 months ago (2016-08-20 09:39:25 UTC) #10
kcc2
4 years, 4 months ago (2016-08-22 16:43:48 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698